Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When adding a rule, use 'peek' to check the existing rules. #595

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

petemill
Copy link

This is so that any encapsulating subscriptions won't fire if the rules change.

See #594.

…capsulating subscriptions won't fire if the rules change
@petemill
Copy link
Author

If I'm right in thinking that addRule does not need to be re-processed if observable.rules() changes, then the peek used in this PR is probably more appropriate. As suggested by @mbest.

@crissdev
Copy link
Member

Thanks @petemill @mbest. I'm going to merge this but after I make some tests against KO 3.4 to and see if there are any other related issues.

@crissdev crissdev added this to the 2.1.0 milestone Dec 8, 2015
crissdev pushed a commit that referenced this pull request Dec 8, 2015
It prevents any encapsulating subscriptions to fire if the rules change.

Closes #595
@crissdev
Copy link
Member

crissdev commented Dec 8, 2015

Merged into v2.1.0 branch. The PR will close itself when merged into master. Thanks for your contribution.

Fixes #594

crissdev pushed a commit that referenced this pull request Aug 22, 2018
It prevents any encapsulating subscriptions to fire if the rules change.

Closes #595
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants