Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a function to swap the minor edges of an evonet object #8

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from

Conversation

jjustison
Copy link

@jjustison jjustison commented Oct 13, 2021

Here is a function that swaps what the evnoet object considers the minor branch. It swaps the hybrid edges of a given hybrid node from net$edge to net$reticulation. This might come in handy for folks that want a bit more customization for their plots

@jjustison jjustison closed this Oct 13, 2021
@jjustison jjustison deleted the swap_minor_edges branch October 13, 2021 16:42
@jjustison jjustison restored the swap_minor_edges branch October 13, 2021 16:42
@jjustison jjustison reopened this Oct 13, 2021
Copy link
Owner

@KlausVigo KlausVigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @jjustison,

thanks for the pull request. Sorry, that it took me some time to review this.
I created a development branch (devel). Can you make the pull request into this branch, I want to try to keep the master branch clean.
The package is accepted in bioconductor and I did not want to make any API changes before the next release on Wednesday.

Just some other tiny changes.
Can you please add the line
#' @importFrom ape node.depth.edgelength
just before #' export in line 15.

Feel free to add yourself as an author to the DESCRIPTION file.

Thanks again,
Klaus

@jjustison jjustison changed the base branch from master to devel October 26, 2021 02:41
@jjustison
Copy link
Author

jjustison commented Oct 26, 2021

Ope, sorry to muddy the master branch before release. Made the changes as requested.
Also, thanks for fixing those issues from earlier, it helped a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants