채팅 관련 컴포넌트 리펙터링 #2188
Draft
채팅 관련 컴포넌트 리펙터링 #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Su-Yong
reviewed
Nov 20, 2023
Comment on lines
114
to
118
| return <EmoticonMessage | ||
| src={url} | ||
| sound={soundUrl} | ||
| alt={alt} | ||
| />; |
There was a problem hiding this comment.
async function으로 JSX.Element를 리턴하는 경우에는 owner를 명시해줘야 제대로 reactivity추적을 제대로 할수 있습니다
그래서 Promise<JSX.Element>형태로 리턴하는 함수는 runWithOwner를 모두 씌워주시면 됩니다
There was a problem hiding this comment.
createEmoticon이 테스트하기 좋은 예시여서 여기에만 댓글을 달았는데, chat-factory2 안에있는 async function모두 바꿔주세요
owner를 잃으면 console에 warning이 뜨니 createEmoticon으로 owner가 제대로 설정되었는지 테스트 해보면 됩니다
There was a problem hiding this comment.
그렇게 할 필요까지는 없을거 같고 그냥 컴포넌트 함수로 반환하도록 고쳤습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
채팅 관련 컴포넌트 전체 코드 구조 개선
Changelog
Migration