WIP: Some docker fixes #3
Conversation
|
@patrickoleary @aronhelser While this isn't 100% ready to go, it's getting pretty close except for the short TODO list I put in the PR description. Feel free to take a look or try it out (obviously need an NVidia graphics card with latest drivers in order to try the gpu-accelerate path). |
| unzip \ | ||
| wget \ | ||
| --no-install-recommends && \ | ||
| apt-get install -y --no-install-recommends \ |
There was a problem hiding this comment.
was dropping build-essential intentional?
There was a problem hiding this comment.
I just moved it to the base image (bionic-python).
Makes the base image (bionic-python) a true Ubuntu 18.04 image, and fixes the containers that base off it to work in that environment. Also adds a path allowing creation of EGL images for the compute and visualization parts of the workflow.
scottwittenburg
force-pushed
the
some-docker-fixes
branch
from
2b3bd1b
to
1c7db0b
Compare
|
ping @patrickoleary @aronhelser This is ready for you guys to take a look. |
|
Looks good to me! +1 |
|
Thanks for mentioning that, I meant to bring it up with you guys at some point. I never removed package cleanup, but rather any time it is needed (if |
|
Were you going to merge this? I think we should start using it! |
|
I think we were holding off because @patrickoleary had a demo last week, but we could probably merge it now. I don't suppose you have tried the branch? I guess if we merge it, and then it turns out only to work for me, I can revisit in a follow-on topic. |
|
I have not tried it, no time right now. Aron can you try it, then merge it.
…On Tue, Aug 27, 2019 at 12:12 PM Scott Wittenburg ***@***.***> wrote:
I think we were holding off because @patrickoleary
<https://github.com/patrickoleary> had a demo last week, but we could
probably merge it now. I don't suppose you have tried the branch? I guess
if we merge it, and then it turns out only to work for me, I can revisit in
a follow-on topic.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3?email_source=notifications&email_token=AAYGDMNNH5BGU3V2QNWJJLLQGVG6PA5CNFSM4ICSLOU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5IJBAA#issuecomment-525373568>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAYGDMPQIRZGHYIMIFUADADQGVG6PANCNFSM4ICSLOUQ>
.
|
|
I tried it out, and had a problem building some of the paraflow images - Scott is looking at it. I was able to build all the images used by docker-compose, and I did the complete workflow for pyfr through visualizer - so that part is good to go. |
|
With NVIDIA?
…On Tuesday, August 27, 2019, Aron Helser ***@***.***> wrote:
I tried it out, and had a problem building some of the paraflow images -
Scott is looking at it. I was able to build all the images used by
docker-compose, and I did the complete workflow for pyfr through visualizer
- so that part is good to go.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3?email_source=notifications&email_token=AAYGDMPP3SCZE5UBKRHR44DQGWJD7A5CNFSM4ICSLOU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5JDRYY#issuecomment-525482211>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAYGDMLTXUCDY62JGDLJT73QGWJD7ANCNFSM4ICSLOUQ>
.
|
|
Not yet - nvidia doesn't work on windows. I'm going to try it out on my linux box next, and try it with the nvidia runtime. |
scottwittenburg
force-pushed
the
some-docker-fixes
branch
from
789aff5
to
202af22
Compare
|
On Linux it works. I started with Docker 19.03, and had to follow these suggestions to enable the 'runtime' keyword in docker-compose. After that, I could run the pyfr workflow all the way through visualization, and the animation was much faster. |
|
+1 Add that information to the main README and merge.
…On Wed, Aug 28, 2019 at 9:57 AM Aron Helser ***@***.***> wrote:
On Linux it works. I started with Docker 19.03, and had to follow these
suggestions
<docker/compose#6691 (comment)> to
enable the 'runtime' keyword in docker-compose. After that, I could run the
pyfr workflow all the way through visualization, and the animation was much
faster.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3?email_source=notifications&email_token=AAYGDMLGCXVRRSJ6MSR3R2DQGZ76HA5CNFSM4ICSLOU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5LGZMA#issuecomment-525757616>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAYGDMLRSR4DUDIRRNP22JTQGZ76HANCNFSM4ICSLOUQ>
.
|
|
I'll add the readme in a separate commit.... |
This still needs a few changes before we can merge it, but it's currently working for me. Some of the changes this PR makes include:
bionic-python) truly Ubuntu 18.04 rather than Debian stretchSome things still left to do before merging: