Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACHIEVEMENT] The Gladiator - achievement for getting all the reaction to a comment #51

Merged
merged 6 commits into from Feb 25, 2017
Merged

[ACHIEVEMENT] The Gladiator - achievement for getting all the reaction to a comment #51

merged 6 commits into from Feb 25, 2017

Commits on Feb 25, 2017

  1. [ACHIEVEMENT] used all reactions 

    This is not including inline comments Yet.
Also, I've noticed there is no collection of reactions for the PR itself. Can we?
The name will change. Also not sure about the beatles.
    @dunaevsky @thatkookooguy
    dunaevsky authored and thatkookooguy committed Feb 25, 2017
    Copy the full SHA
    71e944e View commit details
    Browse the repository at this point in the history

  2. used all reactions - now with returning value in function

    @dunaevsky @thatkookooguy
    dunaevsky authored and thatkookooguy committed Feb 25, 2017
    Copy the full SHA
    4f5c1c1 View commit details
    Browse the repository at this point in the history

  3. All reactions used achvmnt- not including inline comments

    @dunaevsky @thatkookooguy
    dunaevsky authored and thatkookooguy committed Feb 25, 2017
    Copy the full SHA
    be50b3b View commit details
    Browse the repository at this point in the history

  4. Used all reactions - add inline and PR check(still problem with PR) 

    Can't distinguish between when trying to eliminate self reactions.

Also granting to creator is not set yet
    @dunaevsky @thatkookooguy
    dunaevsky authored and thatkookooguy committed Feb 25, 2017
    Copy the full SHA
    c6c1ea5 View commit details
    Browse the repository at this point in the history

  5. fix achievement + implement tests

    @dunaevsky
    dunaevsky committed Feb 25, 2017
    Copy the full SHA
    b9e31d6 View commit details
    Browse the repository at this point in the history

  6. CR comments

    @dunaevsky
    dunaevsky committed Feb 25, 2017
    Copy the full SHA
    808304d View commit details
    Browse the repository at this point in the history