[ACHIEVEMENT] helping hand (#35)

* fixed typo && pullrequest reviewers reference

* added WebStrom ".idea" files to .gitignore (as in Kibibit code-editor)

* added "Helping Hand" achievement

* changed commit.creator to commit author and _.includes to _.find

* added commiter achievement in addition to reviewer achievement

* added reviewer(s) name(s) to committer achievement and vice versa

* changing _.find to the right syntax

* general fixes for helping hand achievement

- don't give the creator the reviewer's achievement
- remove the brackets for `isMultipleCommittedReviewers`
- fix usernames in each other's achievements

* add reviewers to the allPRUsers variable

.gitignore

@@ -1,3 +1,4 @@
 
 node_modules/
-logs/
+logs/
+.idea/

achievements/doubleReview.achievement.js

@@ -9,7 +9,7 @@ var doubleReview = {
 				avatar : 'images/achievements/doubleReview.achievement.gif',
 				name : 'We\'re ready, master',
 				short : _.escape('"This way!"-"No, that way!"'),
-				description : 'double headed code review.<br>It doesn\'t matter who added you, apperantly, both of you are needed for a one man job 😇',
+				description : 'double headed code review.<br>It doesn\'t matter who added you, apparently, both of you are needed for a one man job 😇',
 				relatedPullRequest: pullRequest.id
 			};
 

achievements/helpingHand.achievement.js

@@ -0,0 +1,58 @@
+var _ = require('lodash');
+
+var helpingHand = {
+  name: 'Helping Hand',
+  check: function(pullRequest, shall) {
+    var committedReviewers = reviewersWhoCommittedToPullRequest(pullRequest);
+
+    if (!_.isEmpty(committedReviewers)) {
+
+      var isMultipleCommittedReviewers = committedReviewers.length > 1 ? 's ' : ' ';
+
+      var reviewerAchievement = {
+        avatar: 'images/achievements/helpingHandHelloThere.achievement.jpg',
+        name: 'Helping Hand',
+        short: 'Hello there. Slow going?',
+        description: [
+          'You\'ve committed to ', pullRequest.creator.username,
+          '\'s Pull Request you are reviewing'
+        ].join(''),
+        relatedPullRequest: pullRequest._id
+      };
+
+      var committerAchievement = {
+        avatar: 'images/achievements/helpingHandManInBlack.achievement.jpg',
+        name: 'Helping Hand',
+        short: 'Look, I don\'t mean to be rude but this is not as easy as it looks',
+        description: [
+          'Your reviewer', isMultipleCommittedReviewers,
+          _.map(committedReviewers, 'username').join(', '),
+          ' committed to your Pull Request'
+        ].join(''),
+        relatedPullRequest: pullRequest._id
+      };
+
+      _.forEach(committedReviewers, function(reviewer) {
+        shall.grant(reviewer.username, reviewerAchievement);
+      });
+
+      shall.grant(pullRequest.creator.username, committerAchievement);
+    }
+  }
+};
+
+
+function reviewersWhoCommittedToPullRequest(pullRequest) {
+  var committedReviewers = [];
+
+  _.forEach(pullRequest.commits, function(commit) {
+    if (commit.author.username !== pullRequest.creator.username &&
+      _.find(pullRequest.reviewers, {username: commit.author.username})) {
+      committedReviewers.push(commit.author);
+    }
+  });
+
+  return committedReviewers;
+}
+
+module.exports = helpingHand;

achievements/neverGoFullRetard.achievement.js

@@ -14,7 +14,7 @@ var neverGoFullRetard = {
 				relatedPullRequest: pullRequest.id
 			};
 			shall.grant(pullRequest.creator.username, achieve);
-			_.forEach(pullRequest.reviewer, function(reviewer) {
+			_.forEach(pullRequest.reviewers, function(reviewer) {
 				shall.grant(reviewer.username, achieve);
 			});
 		}

eventManager.js

@@ -292,7 +292,7 @@ var EventManager = function() {
 
               var allPRUsers = [pullRequests[id].creator];
               if (_.isArray(pullRequests[id].reviewers)) {
-                allPRUsers.concat(pullRequests[id].reviewers);
+                allPRUsers = allPRUsers.concat(pullRequests[id].reviewers);
               }
               grantAchievements(allPRUsers, pullRequests[id], io);
             });