Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gtest infra and add include file test #3535

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

qingyuanzNV
Copy link
Contributor

  • Add includer to gtest for include file tests.
  • Move some tests from legacy script to gtest.
  • Turn on debug info flag for non-semantic debug test.

This is the infra part of change from #3513

@arcady-lunarg
Copy link
Contributor

Part of this is addressed by #3375 which I am going to actually merge shortly because I finally figured out the line endings issue, so you're going to have to rebase this, but you also should have fewer CI problems.

@qingyuanzNV
Copy link
Contributor Author

Okay. I'll rebase after that one is merged.

@arcady-lunarg
Copy link
Contributor

The other change has been merged now.

Move some tests from legacy script to gtest.
Turn on debug info flag for non-semantic debug test.
@arcady-lunarg
Copy link
Contributor

Looks like more line ending problems, ugh.

@arcady-lunarg
Copy link
Contributor

Looks like the failures are line ending issues, make sure you're adding both the test file and the result file with line endings that are consistent between the two of them, I think probably unix line endings would work better in this case.

@qingyuanzNV
Copy link
Contributor Author

Yeah, I guessed the same. I'm quite busy with some other deadline recently and I'll get back to this tomorrow.

@qingyuanzNV
Copy link
Contributor Author

@arcady-lunarg sorry to get back to this late. I have addressed the line-ending issue for all test files. Please help review and squash with the following commit message.

Improve gtest infra for includer support and add include file test
- Add includer to gtest for include file tests.
- Move some tests from legacy script to gtest.

@arcady-lunarg arcady-lunarg added the kokoro:run Trigger Google bot runs label Apr 11, 2024
@kokoro-team kokoro-team removed the kokoro:run Trigger Google bot runs label Apr 11, 2024
@arcady-lunarg
Copy link
Contributor

@qingyuanzNV I think you need to move the test back to the runtests script, it is there because it gets run twice with different command line options, for one thing one version is run with -G and the other with -V.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants