New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve gtest infra and add include file test #3535
base: main
Are you sure you want to change the base?
Conversation
Part of this is addressed by #3375 which I am going to actually merge shortly because I finally figured out the line endings issue, so you're going to have to rebase this, but you also should have fewer CI problems. |
Okay. I'll rebase after that one is merged. |
The other change has been merged now. |
Move some tests from legacy script to gtest. Turn on debug info flag for non-semantic debug test.
847b0c9
to
e9eec9b
Compare
Looks like more line ending problems, ugh. |
Looks like the failures are line ending issues, make sure you're adding both the test file and the result file with line endings that are consistent between the two of them, I think probably unix line endings would work better in this case. |
Yeah, I guessed the same. I'm quite busy with some other deadline recently and I'll get back to this tomorrow. |
@arcady-lunarg sorry to get back to this late. I have addressed the line-ending issue for all test files. Please help review and squash with the following commit message.
|
@qingyuanzNV I think you need to move the test back to the runtests script, it is there because it gets run twice with different command line options, for one thing one version is run with |
This is the infra part of change from #3513