Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Build arm64 binaries for macOS #2992

Closed

Conversation

greg-lunarg
Copy link
Contributor

Reverts #2991

Placeholder to reapply #2988. See this previous PR for current status.

@greg-lunarg greg-lunarg changed the title Revert "Revert "Fix: Build arm64 binaries for macOS"" Fix: Build arm64 binaries for macOS Aug 3, 2022
@spnda
Copy link
Contributor

spnda commented Aug 4, 2022

Interesting to double-revert a merge. However, I just noticed something: These are continuous deployments, not the continuous integrations. Why are the tests being run at all? The workflows defined in continuous_integration.yml already test every PR and work perfectly fine. These deployments don't need to be tested again, they're only there to provide the binaries. Removing the tests from all of the deployment workflows would not have any disadvantages imo.

@greg-lunarg
Copy link
Contributor Author

I am just polling a few more folks to decide if it is reasonable to release something that has not been tested. @spnda Can you give any other examples where this is done?

@jeremy-lunarg
Copy link
Contributor

I think we should wait for runner support (github/roadmap#528). It sounds like it might not be that far off.

@spnda We retest in continuous deployment to verify that a merge didn't have unexpected results.

@oscarbg
Copy link

oscarbg commented Mar 23, 2024

Any update?

@arcady-lunarg
Copy link
Contributor

@oscarbg A MacOS arm64 build of glslang is available in the Vulkan SDK. Is there any specific reason you are interested in having this configuration tested in CI?

@oscarbg
Copy link

oscarbg commented Mar 25, 2024

@arcady-lunarg not really.. misunderstood this..

@arcady-lunarg
Copy link
Contributor

This has been implemented by enabling CI to run on macos 14, where the runner is on arm64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants