[Backport to 14] Support both legacy and Khronos version of global variable extensions (#2228) #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riable extensions (KhronosGroup#2228) This is done to provide smooth drivers transition to official extensions. Also updated tests for new extensions to use new tokens after KhronosGroup/SPIRV-Headers@cca08c6 (cherry picked from commit 32786ff)
|
There is an igc test which uses SPV_INTEL_global_variable_decorations fails after #2495. I'll update the test to change SPV_INTEL_global_variable_decorations to SPV_INTEL_global_variable_host_access. |
|
a dozen of new regressions are reported on #2495 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done to provide smooth drivers transition to official extensions.
Also updated tests for new extensions to use new tokens after KhronosGroup/SPIRV-Headers@cca08c6
(cherry picked from commit 32786ff)