[WIP] test: Fix test expectations on x86-32 #2555
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests fail on 32-bit x86:
The causes are all pretty simple differences from the x86-64 expectations in the tests today. E.g.:
Or
With these expectation updates, the test suite passes on x86-32:
However, I do not know how to conditionalize the
CHECK
/CHECK-NEXT
/DWARF
/DWARF-NEXT
statements. I found that some tests in LLVM useX86
/X86-NEXT
/X64
/X64-NEXT
statements, but I do not understand things well enough to use them in these tests. This is where I need help.