[Backport to 18] Missing SPIR-V 1.4 features/changes #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmaksimo
changed the title
When restricting the allowed SPIR-V version using `--spirv-max-version`, some constructs may not be translatable due to being unavailable in older SPIR-V versions. Instead of asserting, report an error. It would be nice to also report the construct leading to the version conflict, but that information isn't readily available at this point. Original commit: cebf8ec
Do nothing for now, as it's not used in translator.
vmaksimo
force-pushed
the
bp18-missed-1.4-features
branch
from
8f196ad
to
ead0c48
Compare
vmaksimo
changed the title
MrSidims
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support OpPtrEqual, OpPtrNotEqual, OpPtrDiff, OpCopyLogical, and CounterBuffer decoration.