Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AndroidManifest.xml #404

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JaredMonkey
Copy link

Adding the necessary meta-data and intent for hello_xr to actually run on devices like Quest and Pico

Adding the necessary meta-data and intent for hello_xr to actually run on devices like Quest and Pico
@CLAassistant
Copy link

CLAassistant commented May 9, 2023

CLA assistant check
All committers have signed the CLA.

@rpavlik
Copy link
Contributor

rpavlik commented May 10, 2023

I'm a little undecided on this one: it seems like meta and pico should not be requiring these extra vendor specific metadata. I can understand requiring standard Android entries (like rumble permission) and the OpenXR specified intent filter, but these vendor specific ones feel like the opposite of what OpenXR should be doing. Will check with the wg in case you haven't already.

@@ -48,6 +48,14 @@
android:theme="@android:style/Theme.Black.NoTitleBar.Fullscreen"
android:exported="true"
tools:ignore="NonResizeableActivity">
<!-- Required meta-data and inent category for Meta devices -->
<meta-data
Copy link
Contributor

@utzcoz utzcoz May 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it needs to moved into the application not activity? You can check the GitHub Action's building failure information.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpavlik-bot rpavlik-bot added the synced to gitlab Synchronized to OpenXR internal GitLab label May 17, 2023
@rpavlik-bot
Copy link
Collaborator

An issue (number 2019) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2019 ), to facilitate working group processes.

This GitHub pull request will continue to be the main site of discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
synced to gitlab Synchronized to OpenXR internal GitLab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants