Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec source for cl_khr_kernel_clock #1103

Merged
merged 7 commits into from
Apr 2, 2024

Conversation

bashbaug
Copy link
Contributor

No description provided.

@bashbaug bashbaug added this to In progress in OpenCL specification maintenance via automation Mar 26, 2024
@bashbaug bashbaug marked this pull request as draft March 26, 2024 16:01
@bashbaug
Copy link
Contributor Author

bashbaug commented Mar 26, 2024

TODOS:

  • Clarify that this is a provisional extension.
  • Remove "ext" from feature test macros.
  • Add undefined behavior sentence to SPIR-V environment spec.

Clarified that this is a provisional extension
Removed ext from feature names and feature test macros
Added undefined behavior description to the SPIR-V environment spec
@bashbaug bashbaug marked this pull request as ready for review March 26, 2024 20:19
@bashbaug
Copy link
Contributor Author

I've fixed all of the TODOs listed above. I think this is ready to go.

@oddhack
Copy link
Contributor

oddhack commented Mar 28, 2024

Aside from minor comments, LGTM from a markup perspective. I am a little confused though, because I thought this extension was in the recently ratified as non-provisional list that Neil sent out (and was thus surprised not to see an appendix for it when constructing #1113).

@oddhack
Copy link
Contributor

oddhack commented Mar 28, 2024

(and was thus surprised not to see an appendix for it when constructing #1113).

To be clear, I am looking at the minutes from March 19th which have a "Ratification #333 - The following extensions are now ratified as final specifications" section including cl_khr_kernel_clock, so I assumed this had previously been published as provisional and wondered where the appendix was. I haven't looked into it any more deeply than that.

@bashbaug
Copy link
Contributor Author

I am a little confused though, because I thought this extension was in the recently ratified as non-provisional list that Neil sent out

Yeah, I was initially confused by this too. The change to a provisional ratification was done at the last minute.

The ratification review package clearly says provisional though, so I believe this is correct. Regardless, I think it would be easier to change from provisional to final than final to provisional.

@bashbaug bashbaug requested a review from alycm April 1, 2024 05:45
@oddhack oddhack mentioned this pull request Apr 1, 2024
@bashbaug
Copy link
Contributor Author

bashbaug commented Apr 2, 2024

Agreed to merge in principle after editorial review.

OpenCL specification maintenance automation moved this from In progress to Reviewer approved Apr 2, 2024
Copy link
Contributor

@alycm alycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bashbaug
Copy link
Contributor Author

bashbaug commented Apr 2, 2024

Thanks, merging. Please file a GitHub issue if any other issues are found, editorial or otherwise.

@bashbaug bashbaug merged commit 75df78c into KhronosGroup:main Apr 2, 2024
2 checks passed
OpenCL specification maintenance automation moved this from Reviewer approved to Done Apr 2, 2024
@bashbaug bashbaug deleted the cl_khr_kernel_clock branch April 2, 2024 20:03
@bcalidas
Copy link

bcalidas commented Apr 3, 2024

Extension text looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants