-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spec source for cl_khr_kernel_clock #1103
Conversation
TODOS:
|
Clarified that this is a provisional extension Removed ext from feature names and feature test macros Added undefined behavior description to the SPIR-V environment spec
I've fixed all of the TODOs listed above. I think this is ready to go. |
Aside from minor comments, LGTM from a markup perspective. I am a little confused though, because I thought this extension was in the recently ratified as non-provisional list that Neil sent out (and was thus surprised not to see an appendix for it when constructing #1113). |
To be clear, I am looking at the minutes from March 19th which have a "Ratification #333 - The following extensions are now ratified as final specifications" section including cl_khr_kernel_clock, so I assumed this had previously been published as provisional and wondered where the appendix was. I haven't looked into it any more deeply than that. |
Yeah, I was initially confused by this too. The change to a provisional ratification was done at the last minute. The ratification review package clearly says provisional though, so I believe this is correct. Regardless, I think it would be easier to change from provisional to final than final to provisional. |
Agreed to merge in principle after editorial review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks, merging. Please file a GitHub issue if any other issues are found, editorial or otherwise. |
Extension text looks good. |
No description provided.