Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fei5484.1.node20actions] Update actions to Node 20 variants #1021

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

somewhatabstract
Copy link
Member

Summary:

This updates our actions to use the Node 20 variants. This should mean almost no more Node 16 deprecation warnings, however, the preactjs/compressed-size-action has no Node 20 variant yet.

Issue: FEI-5484

Test plan:

Put the PR up and see that the workflows run without any Node 16 deprecation warnings - except for those about preactjs/compressed-size-action.

@somewhatabstract somewhatabstract self-assigned this Apr 5, 2024
@somewhatabstract somewhatabstract requested a review from a team April 5, 2024 20:38
Copy link

changeset-bot bot commented Apr 5, 2024

🦋 Changeset detected

Latest commit: 208d5ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@khan-actions-bot khan-actions-bot requested a review from a team April 5, 2024 20:38
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/frontend-infra for changes to .changeset/forty-geckos-begin.md, .github/workflows/codeql-analysis.yml, .github/workflows/dependabot-approve-and-merge.yml, .github/workflows/gerald-pr.yml, .github/workflows/gerald-push.yml, .github/workflows/node-ci-main.yml, .github/workflows/node-ci.yml, .github/workflows/release.yml

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

github-actions bot commented Apr 5, 2024

Size Change: 0 B

Total Size: 4.66 kB

ℹ️ View Unchanged
Filename Size
packages/wonder-stuff-core/dist/browser/es/index.js 1.87 kB
packages/wonder-stuff-sentry/dist/browser/es/index.js 1.66 kB
packages/wonder-stuff-testing/dist/browser/es/index.js 1.13 kB

compressed-size-action

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Merging #1021 (208d5ac) into main (62e4f13) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1021   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files          97       97           
  Lines        1392     1392           
  Branches      359      358    -1     
=======================================
  Hits         1390     1390           
  Misses          1        1           
  Partials        1        1           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62e4f13...208d5ac. Read the comment docs.

@jeresig
Copy link
Member

jeresig commented Apr 5, 2024

@jeremywiebe Were you able to solve the Node 16 error for the compressed-size-action in Perseus?

@somewhatabstract
Copy link
Member Author

@jeremywiebe Were you able to solve the Node 16 error for the compressed-size-action in Perseus?

Regarding this. The repo updated to Node 16 a year ago, but never published a new version. So technically, it's specifying node 12 and GitHub is forcing it to run with Node 16. I would envisage this action is abandoned and we want to plan accordingly (we use it in Perseus, Wonder Stuff, and Wonder Blocks).

@jeremywiebe
Copy link
Contributor

@jeresig @somewhatabstract I don't remember seeing an error with the compressed-size-action, but it's a bit since I worked on this.

I wonder if we should think about forking this action and just maintaining it ourselves in https://github.com/khan/actions ? Or look at different solutions like:

@somewhatabstract somewhatabstract merged commit 509c2a5 into main Apr 8, 2024
8 checks passed
@somewhatabstract somewhatabstract deleted the fei5484.1.node20actions branch April 8, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants