Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable inlay hints for VSCode #1020

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Enable inlay hints for VSCode #1020

merged 2 commits into from
Mar 14, 2024

Conversation

kevinbarabash
Copy link
Member

Summary:

Inlay hints can be useful at see the types for things without having to hover over everything. They can also be useful in understand what args are being passed as what params especially when the args are literals.

This PR enables all of the inlay hints in our .vscode/settings.json. In order to see the inlay hints developers must press and hold Ctrl-Opt at the same time otherwise they're not visible.

If developers want to customize this behaviour they can do so in their User settings.json for VSCode.

Issue: None

Test plan:

  • open a .ts file in VSCode
  • press Ctrl-Opt
  • see all of the inlay hints
Screen Shot 2024-03-12 at 10 23 07 AM

@kevinbarabash kevinbarabash self-assigned this Mar 13, 2024
Copy link

changeset-bot bot commented Mar 13, 2024

🦋 Changeset detected

Latest commit: 214073a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kevinbarabash kevinbarabash requested a review from a team March 13, 2024 18:56
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Merging #1020 (214073a) into main (b88e89f) will increase coverage by 0.07%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1020      +/-   ##
==========================================
+ Coverage   99.85%   99.92%   +0.07%     
==========================================
  Files          97       97              
  Lines        1392     1389       -3     
  Branches      359      343      -16     
==========================================
- Hits         1390     1388       -2     
  Misses          1        1              
+ Partials        1        0       -1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b88e89f...214073a. Read the comment docs.

@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/frontend-infra for changes to .changeset/little-dingos-travel.md

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

Size Change: 0 B

Total Size: 4.66 kB

ℹ️ View Unchanged
Filename Size
packages/wonder-stuff-core/dist/browser/es/index.js 1.87 kB
packages/wonder-stuff-sentry/dist/browser/es/index.js 1.66 kB
packages/wonder-stuff-testing/dist/browser/es/index.js 1.13 kB

compressed-size-action

@kevinbarabash kevinbarabash merged commit 62e4f13 into main Mar 14, 2024
8 checks passed
@kevinbarabash kevinbarabash deleted the enable-inlay-hints branch March 14, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants