Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WB-1676.2: Add a11y features to announce combobox changes to screen readers #2225

Draft
wants to merge 3 commits into
base: combobox-multiple
Choose a base branch
from

Conversation

jandrade
Copy link
Member

@jandrade jandrade commented May 15, 2024

Summary:

TBD

Issue: WB-1676

Test plan:

@jandrade jandrade self-assigned this May 15, 2024
Copy link

changeset-bot bot commented May 15, 2024

🦋 Changeset detected

Latest commit: 2818ebe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@khanacademy/wonder-blocks-dropdown Minor
@khanacademy/wonder-blocks-birthday-picker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 15, 2024

Size Change: +809 B (+0.82%)

Total Size: 99.6 kB

Filename Size Change
packages/wonder-blocks-dropdown/dist/es/index.js 17 kB +809 B (+4.98%) 🔍
ℹ️ View Unchanged
Filename Size
packages/wonder-blocks-accordion/dist/es/index.js 3.78 kB
packages/wonder-blocks-banner/dist/es/index.js 1.53 kB
packages/wonder-blocks-birthday-picker/dist/es/index.js 1.72 kB
packages/wonder-blocks-breadcrumbs/dist/es/index.js 1.13 kB
packages/wonder-blocks-button/dist/es/index.js 4.28 kB
packages/wonder-blocks-cell/dist/es/index.js 2.24 kB
packages/wonder-blocks-clickable/dist/es/index.js 3.29 kB
packages/wonder-blocks-core/dist/es/index.js 3.67 kB
packages/wonder-blocks-data/dist/es/index.js 6.33 kB
packages/wonder-blocks-form/dist/es/index.js 5.33 kB
packages/wonder-blocks-grid/dist/es/index.js 1.36 kB
packages/wonder-blocks-i18n/dist/es/index.js 4.56 kB
packages/wonder-blocks-icon-button/dist/es/index.js 3.21 kB
packages/wonder-blocks-icon/dist/es/index.js 1.06 kB
packages/wonder-blocks-labeled-field/dist/es/index.js 72 B
packages/wonder-blocks-layout/dist/es/index.js 1.89 kB
packages/wonder-blocks-link/dist/es/index.js 2.53 kB
packages/wonder-blocks-modal/dist/es/index.js 5.52 kB
packages/wonder-blocks-pill/dist/es/index.js 1.65 kB
packages/wonder-blocks-popover/dist/es/index.js 4.86 kB
packages/wonder-blocks-progress-spinner/dist/es/index.js 1.51 kB
packages/wonder-blocks-search-field/dist/es/index.js 1.55 kB
packages/wonder-blocks-switch/dist/es/index.js 2.1 kB
packages/wonder-blocks-testing/dist/es/index.js 3.94 kB
packages/wonder-blocks-theming/dist/es/index.js 697 B
packages/wonder-blocks-timing/dist/es/index.js 1.8 kB
packages/wonder-blocks-tokens/dist/es/index.js 1.74 kB
packages/wonder-blocks-toolbar/dist/es/index.js 857 B
packages/wonder-blocks-tooltip/dist/es/index.js 6.91 kB
packages/wonder-blocks-typography/dist/es/index.js 1.49 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented May 15, 2024

A new build was pushed to Chromatic! 🚀

https://5e1bf4b385e3fb0020b7073c-kgncqtgufj.chromatic.com/

Chromatic results:

Metric Total
Captured snapshots 65
Tests with visual changes 5
Total stories 420
Inherited (not captured) snapshots [TurboSnap] 267
Tests on the build 332

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.58%. Comparing base (265751e) to head (2818ebe).

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           combobox-multiple    #2225      +/-   ##
=====================================================
+ Coverage              95.26%   95.58%   +0.31%     
=====================================================
  Files                    251      252       +1     
  Lines                  30046    30262     +216     
  Branches                2453     2476      +23     
=====================================================
+ Hits                   28624    28926     +302     
+ Misses                  1412     1320      -92     
- Partials                  10       16       +6     
Files Coverage Δ
...s-dropdown/src/components/combobox-live-region.tsx 100.00% <100.00%> (ø)
...own/src/components/combobox-multiple-selection.tsx 100.00% <100.00%> (ø)
...wonder-blocks-dropdown/src/components/combobox.tsx 99.61% <100.00%> (+0.01%) ⬆️
...kages/wonder-blocks-dropdown/src/util/constants.ts 100.00% <100.00%> (ø)

... and 24 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 265751e...2818ebe. Read the comment docs.

@jandrade jandrade changed the title Add a11y features to announce combobox changes to screen readers WB-1676.2: Add a11y features to announce combobox changes to screen readers May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant