New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WB-1672: Form fields: Update border color to offBlack50 #2199
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 9b59742 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
color: color.offBlack, | ||
"::placeholder": { | ||
color: color.offBlack64, | ||
}, | ||
}, | ||
error: { | ||
background: `${mix(color.fadedRed8, color.white)}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: This color is now part of the official WB color palette.
Size Change: 0 B Total Size: 93.1 kB
ℹ️ View Unchanged
|
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (f932ae2) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2199" Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2199 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2199 +/- ##
==========================================
+ Coverage 94.24% 95.02% +0.78%
==========================================
Files 247 247
Lines 28576 28575 -1
Branches 2322 2361 +39
==========================================
+ Hits 26931 27153 +222
+ Misses 1645 1422 -223
... and 32 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you Juan!
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-kiblnpgewp.chromatic.com/ Chromatic results:
|
Summary:
For a11y reasons, we are changing the border color from
offBlack16
tooffBlack50
. This will solve a color contrast issue for non-text elements liketextfields and dropdown openers.
This PR updates this color in
TextField
,MultiSelect
andSingleSelect
tomatch these changes.
TextField / LabeledTextField:
MultiSelect / SingleSelect:
Issue: WB-1672
Test plan:
Verify the border color of the
Textfield
,MultiSelect
andSingleSelect
inStorybook and chromatic, and ensure that the color looks as we expect.