Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove long-deprecated khan-exercise.css #875

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jeremywiebe
Copy link
Collaborator

@jeremywiebe jeremywiebe commented Dec 15, 2023

Summary:

Today's the day - rm khan-exercise.css.

The khan-exercise.css stylesheet is a very old set of styles for Perseus. Many of the styles apply to elements that live in webapp and not in Perseus so they don't even belong here. Some are unscoped and so also are just bad practices. Lastly, webapp applies a CSS Reset at the start of it's styles so I suspect most of the unscoped rules are clobbered anyways.

The remaining rules will either exist in webapp/mobile already or be for elements that no longer exist.

This file just confuses things so I'm removing it today!

Issue: --none--

Test plan:

@jeremywiebe jeremywiebe self-assigned this Dec 15, 2023
Copy link
Contributor

github-actions bot commented Dec 15, 2023

Size Change: 0 B

Total Size: 832 kB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.1 kB
packages/kmath/dist/es/index.js 4.25 kB
packages/math-input/dist/es/index.js 79 kB
packages/perseus-core/dist/es/index.js 908 B
packages/perseus-editor/dist/es/index.js 270 kB
packages/perseus-error/dist/es/index.js 877 B
packages/perseus-linter/dist/es/index.js 21.8 kB
packages/perseus/dist/es/index.js 402 kB
packages/pure-markdown/dist/es/index.js 3.77 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

@jeremywiebe jeremywiebe marked this pull request as ready for review December 15, 2023 21:56
@khan-actions-bot khan-actions-bot requested a review from a team December 15, 2023 21:56
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/lovely-seahorses-hide.md, packages/perseus/src/styles/perseus-renderer.less

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #875 (044e74c) into main (20db666) will increase coverage by 1.31%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
+ Coverage   62.24%   63.56%   +1.31%     
==========================================
  Files         406      408       +2     
  Lines       99371    99388      +17     
  Branches     6206     8670    +2464     
==========================================
+ Hits        61851    63172    +1321     
+ Misses      37520    36216    -1304     

Impacted file tree graph

see 31 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20db666...044e74c. Read the comment docs.

Copy link
Contributor

npm Snapshot: Published

🎉 Good news!! We've packaged up the latest commit from this PR (044e74c) and published it to npm. You
can install it using the tag PR875.

Example:

yarn add @khanacademy/perseus@PR875

@handeyeco
Copy link
Contributor

This is great 🎉 Makes me a little nervous with the upcoming mobile app release though.

  • Should we wait to land this until after the release?
  • Do we need a full QE Perseus pass to check for issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants