New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove long-deprecated khan-exercise.css
#875
base: main
Are you sure you want to change the base?
Conversation
Size Change: 0 B Total Size: 832 kB ℹ️ View Unchanged
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #875 +/- ##
==========================================
+ Coverage 62.24% 63.56% +1.31%
==========================================
Files 406 408 +2
Lines 99371 99388 +17
Branches 6206 8670 +2464
==========================================
+ Hits 61851 63172 +1321
+ Misses 37520 36216 -1304 see 31 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (044e74c) and published it to npm. You Example: yarn add @khanacademy/perseus@PR875 |
This is great 🎉 Makes me a little nervous with the upcoming mobile app release though.
|
Summary:
Today's the day -
rm khan-exercise.css
.The
khan-exercise.css
stylesheet is a very old set of styles for Perseus. Many of the styles apply to elements that live in webapp and not in Perseus so they don't even belong here. Some are unscoped and so also are just bad practices. Lastly, webapp applies a CSS Reset at the start of it's styles so I suspect most of the unscoped rules are clobbered anyways.The remaining rules will either exist in webapp/mobile already or be for elements that no longer exist.
This file just confuses things so I'm removing it today!
Issue: --none--
Test plan: