[rm-input-number] 1 - Replace input-number with numeric-input #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1456267 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (820fbdb) and published it to npm. You Example: yarn add @khanacademy/perseus@PR430 |
|
Size Change: -323 B (0%) Total Size: 652 kB
ℹ️ View Unchanged
|
This was referenced Mar 24, 2023
jeremywiebe
force-pushed
the
rm-input-number.1
branch
from
5202dd6
to
76fcaac
Compare
… matched to the implementation
jeremywiebe
force-pushed
the
rm-input-number.1
branch
from
76fcaac
to
1456267
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR starts the process of deleting the
input-numberwidget from Perseus. Existing data referencinginput-numberare now rendered withnumeric-inputwidgets. We use thepropUpgradeswidget option to migrate theinput-numberoptions to equivalentnumeric-inputoptions.Note that this PR contains Flow and Jest failures. I am going to fix/resolve these issues over the next few PRs so that each one is smaller and easier to review. The entire stack will only be landed once everything has been fixed and tested.
Previous PRs in stack:
Issue: LC-616
Test plan:
yarn test packages/perseus/src/widgets/__tests__/numeric-input_test.jsx