Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove perseus-env - no longer used by anything in Perseus #275

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeremywiebe
Copy link
Collaborator

@jeremywiebe jeremywiebe commented Jun 25, 2022

Summary:

This file (and the symbols it exports/attached to window) are no longer used anywhere in Perseus. Removing to clean thingsup.

Issue: "none"

Test plan:

yarn flow
yarn test
rg KhanUtil - 0 results
rg getCurrentFramework - 0 results
etc

@changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2022

⚠️ No Changeset found

Latest commit: 1df3b05

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jeremywiebe jeremywiebe self-assigned this Jun 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2022

Size Change: -17 B (0%)

Total Size: 708 kB

Filename Size Change
packages/perseus/dist/es/index.js 418 kB -17 B (0%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.4 kB
packages/kmath/dist/es/index.js 4.18 kB
packages/math-input/dist/es/index.js 60 kB
packages/perseus-editor/dist/es/index.js 150 kB
packages/perseus-error/dist/es/index.js 825 B
packages/perseus-linter/dist/es/index.js 19.3 kB
packages/pure-markdown/dist/es/index.js 3.74 kB
packages/simple-markdown/dist/es/index.js 12.9 kB

compressed-size-action

@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #275 (1df3b05) into main (988726b) will increase coverage by 3.60%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
+ Coverage   47.55%   51.16%   +3.60%     
==========================================
  Files         537      541       +4     
  Lines       29290    32423    +3133     
  Branches     6477     7376     +899     
==========================================
+ Hits        13930    16588    +2658     
- Misses      15360    15835     +475     
Impacted Files Coverage Δ
packages/perseus/src/util/math.js 30.06% <ø> (+0.69%) ⬆️
testing/test-dependencies.js 32.14% <0.00%> (ø)
vendor/raphael/raphael.js 34.36% <0.00%> (ø)
testing/test-tex.jsx 88.23% <0.00%> (ø)
testing/render-question-with-cypress.jsx 95.45% <0.00%> (ø)
vendor/hubble/hubble.js 36.84% <0.00%> (ø)
packages/perseus/src/util.js 56.91% <0.00%> (+0.32%) ⬆️
...erseus/src/interactive2/movable-polygon-options.js 58.59% <0.00%> (+0.78%) ⬆️
packages/perseus/src/util/tex.js 40.50% <0.00%> (+1.26%) ⬆️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 988726b...1df3b05. Read the comment docs.

Base automatically changed from storybook-render-state-root to main June 27, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant