Update spacing in locked figure settings #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +124 B (0%) Total Size: 833 kB
ℹ️ View Unchanged
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1231 +/- ##
==========================================
+ Coverage 68.68% 69.95% +1.26%
==========================================
Files 468 473 +5
Lines 100702 100814 +112
Branches 7125 10812 +3687
==========================================
+ Hits 69168 70523 +1355
+ Misses 31350 30291 -1059
+ Partials 184 0 -184
... and 145 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
jeremywiebe
approved these changes
May 6, 2024
Comment on lines
+98
to
+99
| frameSource="about:blank" | ||
| previewURL="about:blank" |
There was a problem hiding this comment.
😢 no change needed, but this preview system (and lack of it in Storybook) just makes me sad.
| import type {Meta, StoryObj} from "@storybook/react"; | ||
|
|
||
| export default { | ||
| title: "Perseus Editor/Components/Locked Figures Section", |
There was a problem hiding this comment.
The Perseus Editor part of this can't include spaces. I recently discovered that things were not grouped correctly because of the spaces we had in the title here. I think spaces later on are fine, but for top-level areas, it needs to be PerseusEditor/...
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (eace5ff) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1231If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1231 |
Merged
benchristel
pushed a commit
that referenced
this pull request
May 6, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/math-input@18.1.0 ### Minor Changes - [#1230](#1230) [`db041577d`](db04157) Thanks [@benchristel](https://github.com/benchristel)! - Get `@khanacademy/mathjax-renderer` from NPM, to allow third-party clients of Perseus to install it ### Patch Changes - [#1205](#1205) [`71e74ff64`](71e74ff) Thanks [@benchristel](https://github.com/benchristel)! - Internal: Fix storybook stories for keypad button ## @khanacademy/perseus@22.3.0 ### Minor Changes - [#1210](#1210) [`2d3c3b49a`](2d3c3b4) Thanks [@nishasy](https://github.com/nishasy)! - Limit color set for locked figures in Interactive Graph ### Patch Changes - [#1231](#1231) [`4fae0155d`](4fae015) Thanks [@nishasy](https://github.com/nishasy)! - Adjust spacing in locked point and locked line settings - [#1232](#1232) [`cf1dc61b0`](cf1dc61) Thanks [@nishasy](https://github.com/nishasy)! - Refactor: separate LockedFigureSettingsAccordion component to reduce redundancy - [#1239](#1239) [`f757db589`](f757db5) Thanks [@benchristel](https://github.com/benchristel)! - Fix sizing of interactive graph axis labels on mobile - Updated dependencies \[[`71e74ff64`](71e74ff), [`db041577d`](db04157)]: - @khanacademy/math-input@18.1.0 ## @khanacademy/perseus-editor@6.2.0 ### Minor Changes - [#1210](#1210) [`2d3c3b49a`](2d3c3b4) Thanks [@nishasy](https://github.com/nishasy)! - Limit color set for locked figures in Interactive Graph ### Patch Changes - [#1231](#1231) [`4fae0155d`](4fae015) Thanks [@nishasy](https://github.com/nishasy)! - Adjust spacing in locked point and locked line settings - [#1232](#1232) [`cf1dc61b0`](cf1dc61) Thanks [@nishasy](https://github.com/nishasy)! - Refactor: separate LockedFigureSettingsAccordion component to reduce redundancy - Updated dependencies \[[`2d3c3b49a`](2d3c3b4), [`4fae0155d`](4fae015), [`71e74ff64`](71e74ff), [`cf1dc61b0`](cf1dc61), [`db041577d`](db04157), [`f757db589`](f757db5)]: - @khanacademy/perseus@22.3.0 - @khanacademy/math-input@18.1.0 ## @khanacademy/perseus-dev-ui@1.5.4 ### Patch Changes - [#1220](#1220) [`e3fd10f0e`](e3fd10f) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - ✨ Wrap the navigation controls of the Flipbook inside of a WB Toolbar - Updated dependencies \[[`71e74ff64`](71e74ff), [`db041577d`](db04157)]: - @khanacademy/math-input@18.1.0 Author: khan-actions-bot Reviewers: benchristel Required Reviewers: Approved By: benchristel Checks: ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage, ⏭️ Publish npm snapshot, ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1228
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Update spacing in the Locked Point Settings and Locked Line Settings
accordions so that the settings fit better.
PR includes
Issue: https://khanacademy.atlassian.net/browse/LEMS-1965
Test plan:
yarn jesthttp://localhost:6006/?path=/story/perseus-editor-components-locked-figures-section--with-prod-width
Screenshots
Note: the font styles are ever so slightly off, probably because of global styles in prod vs dev