Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Arrowheads on Locked Lines #1229

Merged
merged 15 commits into from
May 7, 2024
Merged

Show Arrowheads on Locked Lines #1229

merged 15 commits into from
May 7, 2024

Commits on Apr 24, 2024

  1. Implement locked rays

    @nishasy
    nishasy committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    d8d44d8 View commit details
    Browse the repository at this point in the history

  2. purple

    @nishasy
    nishasy committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    17ce7bb View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Add "showArrows" conditional logic to rays.

    Mark Fitzgerald committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    591cc89 View commit details
    Browse the repository at this point in the history

  2. Refactor how line/ray arrowheads are generated and placed in the graph. 

    Move arrowhead property values to a util function.
Add arrowheads to lines.
    Mark Fitzgerald committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    2fd6dc5 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Merge main into branch and adjust for conflicts.

    Mark Fitzgerald committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a439b2f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into lems-1929-show-arrows-on-locked-lines

    Mark Fitzgerald committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    d12424c View commit details
    Browse the repository at this point in the history

  3. Show arrowheads on segments in place of their endpoints, when flag is… 

    … set to 'true'.

Update tests and snapshots accordingly.
    Mark Fitzgerald committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    f334fc5 View commit details
    Browse the repository at this point in the history

  4. Prettier adjustments & changeset.

    Mark Fitzgerald committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    ce5fd5e View commit details
    Browse the repository at this point in the history

  5. Adjust editor to default to "show arrows" when a ray line type is added.

    Mark Fitzgerald committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    b621f67 View commit details
    Browse the repository at this point in the history

  6. Adjust editor to default to "show arrows" when a ray or line, but not… 

    … for segment.
    Mark Fitzgerald committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    073859f View commit details
    Browse the repository at this point in the history

  7. Adjust editor to default to "show arrows" when a locked line is newly… 

    … added to the graph.
    Mark Fitzgerald committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    55cd0a2 View commit details
    Browse the repository at this point in the history

  8. Update unit tests to account for new default settings for show arrows.

    Mark Fitzgerald committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    6ef7bd8 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Refactor to have arrowheads in vector so that movable line can have a… 

    …rrows also (prior changes removed that feature).

Implement other PR comment suggestions.
    Mark Fitzgerald committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    885982d View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Remove "showArrows" option from locked lines and editor. 

    Adjust tests accordingly.
Add unit tests for Arrowhead.
    Mark Fitzgerald committed May 6, 2024
    Configuration menu
    Copy the full SHA
    748cf45 View commit details
    Browse the repository at this point in the history

  2. Merge changes from main. 

    Fix lint errors.
    Mark Fitzgerald committed May 6, 2024
    Configuration menu
    Copy the full SHA
    27d720f View commit details
    Browse the repository at this point in the history