Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook 8 #1147

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Storybook 8 #1147

wants to merge 5 commits into from

Conversation

jeremywiebe
Copy link
Collaborator

Summary:

It kept prompting me, so I finally just did it.

One nice little thing is that Storybook 8 now bundles the Vite turbosnap functionality so when building storybook for Github Pages we can just pass a param instead of using a separate plugin.

Issue: "none"

Test plan:

yarn start is happy

@jeremywiebe jeremywiebe self-assigned this Apr 3, 2024
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Size Change: 0 B

Total Size: 835 kB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.1 kB
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 80.5 kB
packages/math-input/dist/es/strings.js 1.73 kB
packages/perseus-core/dist/es/index.js 908 B
packages/perseus-editor/dist/es/index.js 267 kB
packages/perseus-error/dist/es/index.js 878 B
packages/perseus-linter/dist/es/index.js 21.8 kB
packages/perseus/dist/es/index.js 400 kB
packages/perseus/dist/es/strings.js 3.22 kB
packages/pure-markdown/dist/es/index.js 3.68 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.97%. Comparing base (896a159) to head (9d0e12f).

❗ Current head 9d0e12f differs from pull request most recent head 3752fab. Consider uploading reports for the commit 3752fab to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1147      +/-   ##
==========================================
+ Coverage   69.08%   69.97%   +0.88%     
==========================================
  Files         472      472              
  Lines      101103   100918     -185     
  Branches     7216    10821    +3605     
==========================================
+ Hits        69843    70613     +770     
+ Misses      31082    30305     -777     
+ Partials      178        0     -178     

Impacted file tree graph

see 177 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 896a159...3752fab. Read the comment docs.

Comment on lines -46 to -45
"@storybook/addon-actions": "^7.6.17",
"@storybook/addon-controls": "^7.6.17",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actions, controls, and viewport addons are bundled into the "essentials" addon and so we don't need to depend on them separately.

https://storybook.js.org/integrations/tag/essentials

"@storybook/addon-essentials": "^7.6.17",
"@storybook/addon-links": "^7.6.17",
"@storybook/addon-viewport": "^7.6.17",
"@storybook/react": "^7.6.17",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"@storybook/react" is a dependency of "@storybook/react-vite" so having a direct dependency is redundant.

"style-loader": "^3.3.3",
"typescript": "^5.4.2",
"typescript-coverage-report": "^0.7.0",
"vite-plugin-istanbul": "^5.0.0",
"vite-plugin-turbosnap": "^1.0.3",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turbosnap is now built into the "@storybook/react-vite" bundle and can be enabled with the standard --stats-json argument (see line 146 of this file).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant