Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storybook: implement multi row selection with hold shift #917

Conversation

dangkhoa99
Copy link
Contributor

@dangkhoa99 dangkhoa99 commented Jan 7, 2024

Add example implement multi row selection with hold SHIFT.

Thank you for export staticRowIndex in muiSelectCheckboxProps (#887) so I can implement it more easily.

I hope you can review and develop this feature in the MRT table.

Copy link

vercel bot commented Jan 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
material-react-table ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2024 10:54am
material-react-table-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2024 10:54am

@KevinVandy
Copy link
Owner

@dangkhoa99 Would you be interested in helping contribute this feature to TanStack Table itself? I'm also a TanStack Table maintainer.
Code here: https://github.com/TanStack/table/blob/main/packages/table-core/src/features/RowSelection.ts

@KevinVandy KevinVandy merged commit 570e0d2 into KevinVandy:v2 Jan 9, 2024
3 of 4 checks passed
@dangkhoa99
Copy link
Contributor Author

Sure, I'm interested in contributing to TanStack Table and will do so in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants