Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single group alt #916

Merged
merged 15 commits into from Jan 6, 2024
Merged

Single group alt #916

merged 15 commits into from Jan 6, 2024

Conversation

KevinVandy
Copy link
Owner

No description provided.

Copy link

vercel bot commented Jan 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
material-react-table ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2024 9:58pm
material-react-table-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2024 9:58pm

@KevinVandy
Copy link
Owner Author

@dangkhoa99 I think I have a much simpler implementation with no new APIs. I wonder if this satisfies your use case

image

@KevinVandy
Copy link
Owner Author

I have branched off of your PR so that when merged, you still get credit

@dangkhoa99
Copy link
Contributor

dangkhoa99 commented Jan 7, 2024

in my case, i need addColumnToLeafNode feature, and display column header according to addColumnToLeafNode. Can you add this option? Link

@dangkhoa99
Copy link
Contributor

I think you can set option addColumnToLeafNode ?: 'last-grouping' | string, and 'last-grouping' replace to showOpenedGroup

@KevinVandy
Copy link
Owner Author

@dangkhoa99 By addColumnToLeafNode, do you mean still showing the column that it is grouped by in the list of columns?

@KevinVandy
Copy link
Owner Author

@dangkhoa99 Join the discord for more convos maybe if you can/want

@Menghini
Copy link
Contributor

Menghini commented Jan 9, 2024

Hello, I have already benefited from this feature in my project. However, it would be great to also have the column filters present or the global filter working with this new "remove" feature. I made a post about it at #929 with further information.

@KevinVandy KevinVandy deleted the single-group-alt branch January 13, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants