Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add disabled props to TablePagination #858

Merged
merged 1 commit into from Dec 8, 2023
Merged

Conversation

HanJaeJoon
Copy link
Contributor

disabled props has been added to TablePagination in Material UI since v5.14.18
(https://mui.com/material-ui/api/table-pagination/#props)

disabled props disable pagination only when paginationDisplayMode is pages.
so I fixed disabled props to work regardless of paginationDisplayMode.

  • disabled: false
    image
  • disabled: true
    image

Copy link

vercel bot commented Dec 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
material-react-table ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2023 9:33am
material-react-table-storybook ❌ Failed (Inspect) Dec 7, 2023 9:33am

@KevinVandy
Copy link
Owner

This is not needed, because you can already pass in muiTablePaginationProps.SelectProps.disabled.
I do not intent to recreate every api of the Mui TablePagination component. For v2, the Pagination component is the new base. All the same customizations should mostly still be possible through SelectProps for customizing everything needed for it.

@KevinVandy KevinVandy closed this Dec 7, 2023
@HanJaeJoon
Copy link
Contributor Author

I intended to disable buttons including Select.
How do I disable IconButtons if paginationDisplayMode is default?

@KevinVandy
Copy link
Owner

ok I kind of see what you're saying

@KevinVandy KevinVandy reopened this Dec 8, 2023
@KevinVandy KevinVandy merged commit 87a84c7 into KevinVandy:v2 Dec 8, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants