Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Oromo Translation #799

Closed
wants to merge 1 commit into from

Conversation

drjseifu1991
Copy link
Contributor

Overview:

This pull request adds support for the Oromo language (or) to Material-React-Table by providing an Oromo translation in a new file named or.ts. The translation covers various user interface elements, including action labels, buttons, and user messages. This addition is intended to enhance the user experience for Oromo-speaking users of the Material-React-Table library.

Changes Made:

Added a new localization file, or.ts, containing translations for various UI elements in Oromo.
Translated labels, buttons, and messages, maintaining consistency with the existing localization structure.
Modified the existing localization file to support language selection.
Testing:

I have tested the Oromo translation in the or.ts file to ensure that it correctly displays the translated content in Material-React-Table components. I've checked for proper text rendering, alignment, and compatibility with the library's features.

Checklist:

  • The code follows the style and coding guidelines of the project.
  • I have tested the translation for accuracy and functionality.
  • Documentation has been updated to reflect the addition of Oromo localization.
  • Unit tests (if applicable) have been added or updated to cover the new translation.

Additional Notes:

I'd like to express my gratitude for the opportunity to contribute to Material-React-Table and make it more accessible to Oromo-speaking users. If there are any changes or further improvements needed, please don't hesitate to let me know.

@KevinVandy
Copy link
Owner

Hey, I'm running these through google translate. Is Google wrong?

image

@drjseifu1991
Copy link
Contributor Author

Hey, I'm running these through google translate. Is Google wrong?

image

Yeah, you are right Google doesn't translate the Afan Oromo language correctly. I will look for correct translation as I did for Amharic language.

@KevinVandy
Copy link
Owner

Hey, I'm running these through google translate. Is Google wrong?
image

Yeah, you are right Google doesn't translate the Afan Oromo language correctly. I will look for correct translation as I did for Amharic language.

I'm trying to understand. Are the translations you provided accurate and ok? Or do you not know? I understand that when I was checking your translations on Google, that Google translate might be inaccurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants