Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"select" event can return a null item even when the nullableSelect property is set to false #589

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tbl0605
Copy link
Contributor

@tbl0605 tbl0605 commented Sep 6, 2023

Hi,
Sometimes the "select" event doesn't return a non-null element when used this way:

<vue-simple-suggest
   @select="setValueFromSuggestion"
   ...

To reproduce the problem with a vue-simple-suggest component:

  1. write something in the input field
  2. hover the suggestions with the mouse (but don't select a suggestion)
  3. press enter (the focus must still be in the input field)
  4. the setValueFromSuggestion function will retrieve an null/undefined item

Fortunately, the fix is quite simple.

Thierry.

tbl0605 added a commit to tbl0605/vue-simple-suggest that referenced this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant