Fixes #33525 - Add debs packages_restrict_latest #9671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #33525 |
m-bucher
force-pushed
the
feature/debs_api_latest
branch
from
93a1677
to
62a5c67
Compare
m-bucher
force-pushed
the
feature/debs_api_latest
branch
2 times, most recently
from
a6fe79d
to
9875519
Compare
m-bucher
force-pushed
the
feature/debs_api_latest
branch
from
9875519
to
6835c26
Compare
m-bucher
force-pushed
the
feature/debs_api_latest
branch
from
6835c26
to
91d6332
Compare
|
Can you add some benchmark values here? https://ruby-doc.org/stdlib-2.5.3/libdoc/benchmark/rdoc/Benchmark.html How can we get this fast? |
m-bucher
force-pushed
the
feature/debs_api_latest
branch
from
91d6332
to
1142695
Compare
adamruzicka
approved these changes
Feb 7, 2024
Comment on lines
+108
to
+112
| return relation.joins( | ||
| "LEFT OUTER JOIN(#{relation.to_sql}) AS katello_debs2 ON " \ | ||
| 'katello_debs.name = katello_debs2.name AND katello_debs.architecture = katello_debs2.architecture AND ' \ | ||
| 'deb_version_cmp(katello_debs.version, katello_debs2.version) < 0 ' \ | ||
| ).where('katello_debs2.id IS NULL') |
There was a problem hiding this comment.
Capturing things we talked about live: If I were doing this I'd probably drop the explicit return and used a squiggly heredoc, but that's just personal preference so feel free to ignore.
There was a problem hiding this comment.
Since most of the code was shamelessly copied over from app/models/katello/rpm.rb, I would keep it that way for being consistent.
Eventually, we should think about enforcing a certain style through rubocop. AFAIK Katello's rubocop rules are currently pretty flexible.
m-bucher
force-pushed
the
feature/debs_api_latest
branch
from
1142695
to
3207034
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should implement the
packages_restrict_latestparameter, but I am not sure I really want to have this merged, because it does not scale well at all.This originates in the way we compare debian versions and the fact that we have to compare them and are not able to simply sort them.
Maybe some kind of restriction to a max number of packages is in order for this to be usable.