Drop anemone and use Spidr for Repo discovery #10947
Conversation
|
Doesn't look crazy? Only dep is nokogiri, which we have anyway, tested on modern rubies. Why not. |
sjha4
force-pushed
the
anemone
branch
2 times, most recently
from
cc6dee6
to
934292d
Compare
|
I am seeing significant performance difference with what's on the PR vs the existing workflow..Looking at ways to speed this up..Will push updates when I get the performance sorted. Update: Should be good to go with latest commit. |
sjha4
changed the title
app/lib/katello/repo_discovery.rb
Outdated
|
|
||
| def process_page_urls(urls) | ||
| urls.each do |url| | ||
| url = url.to_s |
There was a problem hiding this comment.
I think this is a bad idea. The URL object is way more valuable and I'd only add it to @to_follow with to_s.
There was a problem hiding this comment.
We don't necessarily use the URL object properties once we have the list of URLs in the page. It's just matching strings after that point..Becomes easier to pass that around and work with it IMO?
There was a problem hiding this comment.
Updated it in latest push to pass URL object.
To Do:
What are the changes introduced in this pull request?
Considerations taken when implementing this change?
What are the testing steps for this pull request?
bundle install
Go to Content > Product > Repo discovery
Run repo discovery.