[WIP] Fixes #37194 - Uses ENV option for RHSM and UPSTREAM_RHSM api url #10902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthaa
changed the title
jeremylenz
reviewed
Feb 21, 2024
| @@ -74,9 +74,13 @@ def owner_upstream_update(upstream, _options) | |||
| upstream['idCert']['key'], ca_file, params) | |||
| end | |||
|
|
|||
| def upstream_api_url(upstream) | |||
| upstream['apiUrl'] || ENV['UPSTREAM_REDHAT_RHSM_API_URL'] || API_URL | |||
There was a problem hiding this comment.
In upstream_job.rb the variable is called REDHAT_RHSM_API_URL; here it's UPSTREAM_REDHAT_RHSM_API_URL. Is that intended?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Considerations taken when implementing this change?
What are the testing steps for this pull request?