Fixes #36716 - Add task to fix candlepin DB #10740
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36716 |
ekohl
reviewed
Sep 15, 2023
|
|
||
| # find_missing associations | ||
| Katello::Resources::Candlepin::Product.all(owner['key']).each do |cp_product| | ||
| katello_product = Katello::Product.find_by_cp_id(cp_product['id'], Organization.find_by(label: owner['key'])) |
There was a problem hiding this comment.
Perhaps this will be cached, but I'd pull the org bit out of the loop. At line 8 you already have label = owner['key'] so I'd add it after that.
| content_in_cp = cp_product['productContent'].length | ||
| content_in_katello = katello_product.contents.count | ||
| logger.debug("Product has #{content_in_cp} content entries in Candlepin and #{content_in_katello} in Katello") | ||
| if content_in_cp != content_in_katello |
There was a problem hiding this comment.
If there's a mismatch that where one has X & Y and the other has X & Z this will not fix it. If Katello has a superset of Candlepin then it will always show up. Would it make sense to always compare the two and sync them, regardless of the number?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is doing similar things than https://github.com/ATIX-AG/orcharhino-scripts/tree/main/find_missing_candlepin_product_contents
This rake-task tries to fix the Candlepin Product-Content associations. It might be that this does not fix all the issues that the above script will fix. But the rake-task will do it in a cleaner way ;-)