Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Pulp 2 Smart Proxy status code #10721

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Sep 6, 2023

What are the changes introduced in this pull request?

It drops the Pulp 2 Smart Proxy status extensions.

Considerations taken when implementing this change?

These were likely not triggered anymore because the Pulp 2 features were never present.

What are the testing steps for this pull request?

Go to the Smart Proxies overview and for every Smart Proxy it should still render well. I forgot if there's a Pulp 3 tab today, but if there is, it should still be present after.

@ianballou
Copy link
Member

Guessing we missed this since it didn't show up in triage via redmine, mind adding one so we can get it on our job board?

@ekohl ekohl force-pushed the drop-pulp-2-smart-proxy-code branch from bd0f12f to 8559d28 Compare April 26, 2024 09:01
@ekohl ekohl marked this pull request as ready for review April 26, 2024 09:01
Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

engine.rb still has ::SmartProxiesController.include Katello::Concerns::SmartProxiesControllerExtensions in it, removing that should fix the tests.

These were likely not triggered anymore because the Pulp 2 features were
never present.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants