ISSUE-405: init commit with simple code gen #584
Conversation
|
|
…ing new supported views
OvsyannikovMaksim
requested review from
matzuk,
eakurnikov and
RuslanMingaliev
as code owners
|
|
||
| @Test | ||
| fun checkCodeGen() { | ||
| val jarFile = File("src/main/java/com/kaspresso/components/pageobjectcodegen/createKtfromDump.jar") |
There was a problem hiding this comment.
it will be better to move .jar file in separate folder (as adbserver does)
|
|
||
| for (element in screenElements) { | ||
| when (element.viewType) { | ||
| "ImageView" -> importsList.add("import io.guthub.kakaocup.kakao.image.KImageView") |
There was a problem hiding this comment.
nit: would be better to move string literals into constants or even evaluate package dynamically KImageView::class.qualifiedName
|
|
||
| object SupportedViews { | ||
| val collectableElements = listOf("android.widget.Button", "android.widget.TextView", "android.widget.ImageView") | ||
| val elementsWithChild = listOf("androidx.recyclerview.widget.RecyclerView") |
There was a problem hiding this comment.
Why only recycler view? Are there any problems with the scroll view, pager, horizontal scroll view etc.?
| * output: | ||
| * Kotlin file with screen code in the same directory as jar execute | ||
| */ | ||
| fun main(vararg args: String) { |
There was a problem hiding this comment.
Please, write more documentation (comments, methods documentation or even wiki file like we have in the docs/ folder). Some areas of your code are hard to understand. It would be easier to maintain your code if you express the concept behind code generation
…opy it to artifacts
No description provided.