Add Kaspresso plugin #417
Add Kaspresso plugin #417
Conversation
|
|
VladislavSumin
requested review from
matzuk,
AzamatCherchesov,
eakurnikov,
RuslanMingaliev and
Nikitae57
as code owners
| logger.d("The created adbCommand=$adbCommand") | ||
| cmdCommandPerformer.perform(adbCommand) | ||
| val adbCommand = "${ adbServerPort?.let { "-P $adbServerPort " } ?: "" }-s $deviceName ${command.body}" | ||
| logger.d("The created adbCommand=adb $adbCommand") |
There was a problem hiding this comment.
Would be cool to print out actual adb path since it's configurable. Otherwise it may mislead someone during adb related issues debugging
There was a problem hiding this comment.
this good idea. I'm add print adb path to log at server startup.
|
|
||
| fun startDevicesObserving() { | ||
| fun startDevicesObservingSync() { |
There was a problem hiding this comment.
nit: I would just mention that this method is blocking in documentation as you did in AdbCommandPerformer::perform. I think blocking behavior is an expected one. Another hint is that there's startDevicesObservingAsync
There was a problem hiding this comment.
yes, I'm add documentation to this methods
| @@ -11,6 +11,6 @@ android { | |||
| dependencies { | |||
| implementation(libs.kotlinStdlib) | |||
| implementation(libs.appcompat) | |||
| implementation(projects.adbServer.adbserverDevice) | |||
| implementation("com.kaspersky.android-components:adbserver-device") | |||
There was a problem hiding this comment.
nit: would be cool to use toml
There was a problem hiding this comment.
toml require to set version, yes in this case we can set any version, but i thing current way is more clear in this situation
| dependencies { | ||
| classpath(libs.kotlinPlugin) | ||
| classpath(libs.androidPlugin) | ||
| classpath("com.kaspersky.kaspresso:kaspresso-plugin") |
There was a problem hiding this comment.
nit: would be cool to use toml
| @@ -21,8 +22,8 @@ dependencies { | |||
| implementation(libs.constraint) | |||
| implementation(libs.multidex) | |||
|
|
|||
| androidTestImplementation(projects.kaspresso) | |||
| androidTestImplementation(projects.allureSupport) | |||
| androidTestImplementation("com.kaspersky.android-components:kaspresso") | |||
There was a problem hiding this comment.
nit: would be cool to use toml
| @@ -52,14 +53,14 @@ dependencies { | |||
| implementation(libs.lifecycleViewModelComposeKtx) | |||
| implementation(libs.composeRuntimeLiveData) | |||
|
|
|||
| androidTestImplementation(projects.kaspresso) | |||
| androidTestImplementation(projects.composeSupport) | |||
| androidTestImplementation("com.kaspersky.android-components:kaspresso") | |||
There was a problem hiding this comment.
nit: would be cool to use toml
…tachedDevicesByAdb function call
| /** | ||
| * @param adbPath - path to adb binary | ||
| */ | ||
| class AdbCommandPerformer( |
There was a problem hiding this comment.
| class AdbCommandPerformer( | |
| class AdbCommandExecutor( |
There was a problem hiding this comment.
Oh, I found CmdCommandPerformer exists already
| group = "com.kaspersky.kaspresso" | ||
| gradlePlugin { | ||
| plugins { | ||
| create("SignerPlugin") { |
There was a problem hiding this comment.
Not a SignerPlugin
| } | ||
|
|
||
| private val devices: MutableCollection<DeviceMirror> = mutableListOf() | ||
| private var isRunning = AtomicBoolean(false) |
There was a problem hiding this comment.
Is it accessed from multiple threads?
Add Kaspresso plugin to implement issue #247
What changed:
enableFeaturePreviewfor features that enabled by defaultcompose-support&&allure-supportto satisfy gradle conventionsOut of scope for current pr: