-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide Jenkins job config to publish a release #79
Conversation
07479ec
to
56530f2
Compare
node('rhel8'){ | ||
if(publishToMarketPlace.equals('true')){ | ||
timeout(time:5, unit:'DAYS') { | ||
input message:'Approve deployment?', submitter: 'apupier, jraez, mariasde, ryordan, mmelko' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems the timeout on jenkins on first run on a specific node is still not enough... will need to wait for the next release of Kaoto UI or wait to get rid of docker to try again EDIT: using binary versions do the trick |
56530f2
to
5d4ff2c
Compare
part of KaotoIO#4 Signed-off-by: Aurélien Pupier <apupier@redhat.com>
5d4ff2c
to
a329e99
Compare
|
||
* Check that the version in package.json has not been published yet | ||
* If already published: | ||
* Update version in `package.json` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this and for creating a tag it might be beneficial to look at the script that María has just added for kaoto-ui
: KaotoIO/kaoto-ui#943
But that is just a suggestion in case you think it would be useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported #94
* Wait few minutes and check that it has been published on [VS Code Marketplace](https://marketplace.visualstudio.com/items?itemName=redhat.vscode-kaoto) and [Open VSX Marketplace](https://open-vsx.org/extension/redhat/vscode-kaoto) | ||
* Keep build forever on Jenkins CI for later reference and edit build information to indicate the version | ||
* Prepare next iteration: | ||
* Update version in `package.json` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will you be wanting to append -dev
to the version as well, similar to how we will be doing for kaoto-ui
? If so, I guess this would be good to indicate on here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would prefer to test it in another iteration. I have no idea if it can cause troubles for VS Code. It sounds like a different topic than the goal of this PR. it wasn't documented before but it was using a non -dev version. I reported #93
part of #4
works with https://gitlab.cee.redhat.com/codeready-studio/cci-config/-/merge_requests/653
The job was working with locally built Jenkins instance but I'm unable to restart it. I stopped ti to have a completely clean one. So cannot show proof it is working :'-(Can be seen here http://10.39.192.130:8080/job/Fuse/job/VSCode/job/vscode-kaoto-release/1/ (with Red Hat VPN and as long as I keep the instance running on my local machine). the job parameters has been slightly modified to be able to run. We will need this branch to be merged before it works on official jenkins.
it is mostly aligned from VS Code Yaml https://github.com/redhat-developer/vscode-yaml/blob/main/Jenkinsfile . the difference is that I removed the pre-release part as it is not working. We can get back to it later. And removed the specific platform part as we do not have ones yet, can wait for a second iteration.
Note: The pre-release part not working has published a pre-release with a wrong number on VS Code Marketplace, so I might need to increment the version for the first release. Not sure though as we will upload with a specific build id. To be tested at the release time. (we can see that is a pre-release only inside VS Code when trying to install, the VS Code marketplace UI is always behind in terms of functionalities)