Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Jenkins job config to publish a release #79

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

apupier
Copy link
Member

@apupier apupier commented Nov 14, 2022

part of #4

works with https://gitlab.cee.redhat.com/codeready-studio/cci-config/-/merge_requests/653

The job was working with locally built Jenkins instance but I'm unable to restart it. I stopped ti to have a completely clean one. So cannot show proof it is working :'-(
Can be seen here http://10.39.192.130:8080/job/Fuse/job/VSCode/job/vscode-kaoto-release/1/ (with Red Hat VPN and as long as I keep the instance running on my local machine). the job parameters has been slightly modified to be able to run. We will need this branch to be merged before it works on official jenkins.

it is mostly aligned from VS Code Yaml https://github.com/redhat-developer/vscode-yaml/blob/main/Jenkinsfile . the difference is that I removed the pre-release part as it is not working. We can get back to it later. And removed the specific platform part as we do not have ones yet, can wait for a second iteration.

Note: The pre-release part not working has published a pre-release with a wrong number on VS Code Marketplace, so I might need to increment the version for the first release. Not sure though as we will upload with a specific build id. To be tested at the release time. (we can see that is a pre-release only inside VS Code when trying to install, the VS Code marketplace UI is always behind in terms of functionalities)

@apupier apupier force-pushed the 4-provideJobToPublishRelease branch 11 times, most recently from 07479ec to 56530f2 Compare November 15, 2022 09:32
node('rhel8'){
if(publishToMarketPlace.equals('true')){
timeout(time:5, unit:'DAYS') {
input message:'Approve deployment?', submitter: 'apupier, jraez, mariasde, ryordan, mmelko'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kahboom @mmelko @Delawen Can you confirm that it is your Red Hat id please?

it-tests/BasicFlow.test.ts Outdated Show resolved Hide resolved
@apupier apupier marked this pull request as ready for review November 15, 2022 11:11
@apupier apupier requested review from a team and removed request for a team November 15, 2022 11:11
@apupier
Copy link
Member Author

apupier commented Nov 15, 2022

seems the timeout on jenkins on first run on a specific node is still not enough... will need to wait for the next release of Kaoto UI or wait to get rid of docker to try again

EDIT: using binary versions do the trick

part of KaotoIO#4

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier requested a review from a team November 16, 2022 13:50

* Check that the version in package.json has not been published yet
* If already published:
* Update version in `package.json`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this and for creating a tag it might be beneficial to look at the script that María has just added for kaoto-ui: KaotoIO/kaoto-ui#943

But that is just a suggestion in case you think it would be useful.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reported #94

* Wait few minutes and check that it has been published on [VS Code Marketplace](https://marketplace.visualstudio.com/items?itemName=redhat.vscode-kaoto) and [Open VSX Marketplace](https://open-vsx.org/extension/redhat/vscode-kaoto)
* Keep build forever on Jenkins CI for later reference and edit build information to indicate the version
* Prepare next iteration:
* Update version in `package.json`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will you be wanting to append -dev to the version as well, similar to how we will be doing for kaoto-ui? If so, I guess this would be good to indicate on here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would prefer to test it in another iteration. I have no idea if it can cause troubles for VS Code. It sounds like a different topic than the goal of this PR. it wasn't documented before but it was using a non -dev version. I reported #93

@apupier apupier merged commit cb7779b into KaotoIO:main Nov 17, 2022
@apupier apupier deleted the 4-provideJobToPublishRelease branch November 17, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants