fix: Added CustomLongTextField and using it for 'Expression', 'Sasl Jaas Config' fields #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivamG640
force-pushed
the
Fix-1043
branch
5 times, most recently
from
a184f0d
to
009a7df
Compare
lordrip
reviewed
May 6, 2024
|
|
||
| export const CustomLongTextField: FunctionComponent<LongTextFieldProps> = (props) => { | ||
| return ( | ||
| <LongTextField className="custom-long-test-field" {...props} inputRef={props.ref} rows={1} autoResize={true} /> |
There was a problem hiding this comment.
In the future, we could reduce the boilerplate a bit. Nothing to action at the moment, we can leave it for the next PR
Suggested change
| <LongTextField className="custom-long-test-field" {...props} inputRef={props.ref} rows={1} autoResize={true} /> | |
| <LongTextField className="custom-long-test-field" {...props} inputRef={props.ref} rows={1} autoResize /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1043
However there are some issues with this new CustomLongTextField listed Following:
The new field is interacting with the CSS of CustomNestField's ExpandableSection. Hence it doesn't load correctly for Kafka's Sasl Jaas Config:
Note that once the field is click and you start adding some text, the field automatically corrects. Also the field loads correctly if we load the ExpandableSection as Expanded by adding the isExpanded attribute always.