feat(CanvasToolbar): Add DSL Selector #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to create new entities, a DSL Slector component needs to be added. This commit adds said component divided in 3 sections: 1. `ChangeDSLModal`: A modal to warn the user whenever the DSL is being changed since the existing integration will be removed 2. `DSLSelectorToggle`: The DSL Button itself 3. `DSLSelector`: The main entrypoint for the DSL Selector, this component is in charge of combining both `DSLSelectorToggle` and the `ChangeDSLModal` components relates: KaotoIO#1030
lordrip
force-pushed
the
feat/add-dsl-selector
branch
from
cdb3927
to
8938c21
Compare
igarashitm
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In order to create new entities, a DSL Slector component needs to be added.
Changes
This commit adds said component divided into 3 sections:
ChangeDSLModal: A modal to warn the user whenever the DSL is being changed since the existing integration will be removedDSLSelectorToggle: The DSL Button itselfDSLSelector: The main entry point for the DSL Selector, this component is in charge of combining bothDSLSelectorToggleand theChangeDSLModalcomponentsScreenshots
DSLSelectorToggle
ChangeDSLModal
relates: #1030