feat(Canvas): Add new entities to the Canvas #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordrip
force-pushed
the
feat/add-entities-menu
branch
11 times, most recently
from
4bf2f0e
to
f0fd955
Compare
lordrip
changed the title
igarashitm
approved these changes
Apr 30, 2024
lordrip
force-pushed
the
feat/add-entities-menu
branch
2 times, most recently
from
7f4d23c
to
1ccdafa
Compare
Currently, setting the current DSL and creating a new entity are tied together in a single step in the NewFlow component. This commit split that functionality in two separate buttons: 1. DSL Selector: Meant to choose the current DSL and therefore determine which type of entities can be added into the Canvas 2. NewEntity: This is for adding new entities, supported by the current DSL, or said in a different way, allows to add entities from the current CamelResource registry. The existing functionality from the CanvasEmptyState is preserved for now. In addition to that, when removing all routes, a new route won't be created by default. fix: KaotoIO#1030
lordrip
force-pushed
the
feat/add-entities-menu
branch
from
1ccdafa
to
76b39db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, setting the current DSL and creating a new entity are tied together in a single step in the NewFlow component.
This commit split that functionality into two separate buttons:
DSL Selector: Meant to choose the current DSL and therefore determine which type of entities can be added to the Canvas
NewEntity: This is for adding new entities, supported by the current DSL, or said differently, allowing to add entities from the current CamelResource registry.
Notes
The existing functionality from the CanvasEmptyState is preserved for now.
In addition to that, when removing all routes, a new route won't be created by default.
Screenshots
DSL Selector
New entity
Toolbar with Camel Route DSL
Toolbar with Kamelet DSL
Toolbar with Pipe
fix: #1030