Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expression field should use the resizable text field component #1043

Closed
lhein opened this issue Apr 26, 2024 · 0 comments · Fixed by #1050
Closed

Expression field should use the resizable text field component #1043

lhein opened this issue Apr 26, 2024 · 0 comments · Fixed by #1050
Assignees
@shivamG640
Labels
canvas/config-form Configuration form related issues ui/ux This issue is about improving the UI / UX
Milestone
2.0.0

Comments

@lhein
Copy link
Contributor

lhein commented Apr 26, 2024 •
edited

The expression field is currently a text area. @shivamG640 has been working on a resizable text field which would be a good replacement here.
@lhein lhein added canvas/config-form Configuration form related issues ui/ux This issue is about improving the UI / UX labels Apr 26, 2024
@lhein lhein added this to the 2.0.0 milestone Apr 26, 2024
This was referenced Apr 29, 2024
Closed
Merged
lordrip added a commit to lordrip/kaoto that referenced this issue May 2, 2024
@lordrip
fix(CanvasForm): Add missing ref into CustomLongTextField
e1dd3a7 
Patternfly's `TextArea` component requires using a `ref` in order to
provide automatic height.

Unfortunately, with React function components, `ref` are not directly possible, so a workaround is needed.

This commit restores the commented lines and also add the missing `ref`
object.

relates: KaotoIO#1043
@lordrip lordrip mentioned this issue May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivamG640 shivamG640

Labels
canvas/config-form Configuration form related issues ui/ux This issue is about improving the UI / UX
Projects
Kanban Board
Status: Done
Milestone
2.0.0
2 participants
@lhein @shivamG640