Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

fix(native-build): Fix native build on Windows on publishing #837

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

apupier
Copy link
Member

@apupier apupier commented Aug 24, 2023

note that another workaround was applied in another file using --% when on Windows: https://github.com/KaotoIO/kaoto-backend/pull/690/files

NOTE: it will fix the native build part but the native executable standalone job part will still fail due to other problems, see #839

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #837 (b6d8729) into main (5dd4941) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head b6d8729 differs from pull request most recent head d987706. Consider uploading reports for the commit d987706 to get more accurate results

@@             Coverage Diff              @@
##               main     #837      +/-   ##
============================================
- Coverage     70.56%   70.50%   -0.06%     
  Complexity      199      199              
============================================
  Files            69       69              
  Lines          3340     3340              
  Branches        558      558              
============================================
- Hits           2357     2355       -2     
- Misses          766      768       +2     
  Partials        217      217              

see 1 file with indirect coverage changes

note that another workaround was applied in another file using `--%`
when on Windows: https://github.com/KaotoIO/kaoto-backend/pull/690/files

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.8% 1.8% Duplication

@apupier apupier marked this pull request as ready for review August 24, 2023 13:54
@apupier apupier requested a review from a team August 24, 2023 13:54
@apupier apupier merged commit 92499d3 into KaotoIO:main Aug 24, 2023
17 checks passed
@apupier apupier deleted the fixNativeBuildOnWindows branch August 24, 2023 22:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants