Allow gunicorns after 20.0.0 #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Bug
techman83
approved these changes
Nov 30, 2019
| @@ -19,7 +19,7 @@ | |||
| 'requests', | |||
| 'flask', | |||
| 'internetarchive', | |||
| 'gunicorn>=19.9,<20.0.0', | |||
| 'gunicorn>=19.9,!=20.0.0', | |||
| 'discord', | |||
There was a problem hiding this comment.
We could probably just require >20.0.0, but it doesn't really make much difference for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
gunicorn is currently pinned to version 19.9.0.
Cause
The 20.0.0 release broke support for the factory pattern, which we use: benoitc/gunicorn#2159
Changes
Version 20.0.1 fixed the issue (20.0.2 includes notes for 20.0.1):
https://github.com/benoitc/gunicorn/releases/tag/20.0.2
I tried it out (with 20.0.3) and it seems to work, so now the pin is changed to just exclude 20.0.0.
Fixes #85.