Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker container #15

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Docker container #15

wants to merge 9 commits into from

Conversation

luc122c
Copy link

@luc122c luc122c commented Jun 21, 2021

Hi there. I found myself wanting to use this on a number of machines which all had docker installed. I quickly build your script into a distroless docker container. I've also setup a Github action to publish it as a package so it's available more widely.

@KNawm
Copy link
Owner

KNawm commented Jun 21, 2021

Hey, thanks for the contribution but I'm not sure if it would be very useful, mind sharing your opinion?

@luc122c
Copy link
Author

luc122c commented Jun 22, 2021

As I mentioned, this is useful when you want to use this application on a system which may not have node/npm installed, but does have a docker runtime. You can easily use this in a single command without having to install any software. With the --rm flag, there is no extra cleanup required (uninstalling etc). The same command can be used on multiple systems with the exact same results, regardless of the environment.

@apalfrey
Copy link

Was hoping for something like this, tested it on my server and it works great!

@agneevX
Copy link

agneevX commented Jun 30, 2021

Can Multiarch support be added?

@luc122c
Copy link
Author

luc122c commented Jun 30, 2021

I used a distroless image as a base for performance and security. There is a discussion about multi-arch support here: GoogleContainerTools/distroless#346. Once this happens, it should filter upstream to this image.

@CappyT
Copy link

CappyT commented Sep 22, 2023

This is perfect ffor speedtesting K8s on-prem nodes and my swarm of Flatcar linux vms

@daluu
Copy link

daluu commented Oct 5, 2023

I see someone posted up a docker version of this at https://hub.docker.com/r/p3terx/speed-cloudflare

@@ -23,3 +23,7 @@
```bash
npx speed-cloudflare-cli
```
or
```bash
docker run --rm ghcr.io/luc122c/speed-cloudflare-cli:master
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if/when ready to merge, this probably needs to be renamed for the target repo this links to?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow file pushes to github.repository so currently, it publishes to my fork. You're correct that when merging, it would need updating to the new location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants