Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pico quickpin #855

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Allstreamer
Copy link
Contributor

Create Raspberry PI pico quickpin based on the Pico Docs. (Also tested on Pico H)

This is because it is compatible with the Pico H and Pico W
Copy link
Collaborator

@xs5871 xs5871 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pi Pico doesn't have a pro micro footprint. It would need a seperate footprint directory.

@Allstreamer
Copy link
Contributor Author

Not sure what would be the best structure.
Right now it's compatible with both the pico H & pico W so i was thinking of naming it pico but that would make the import:

from kmk.quickpins.pico.pico import pinout

which feels a bit weird,
i'm thinking of making it top level or making a raspberry pi folder?
IDK not sure if i should just keep the name as pico.

For Refrence:

# Pico folder
from kmk.quickpin.pico.pico import pinout

# Top Level
from kmk.quickpin.pico import pinout

# Raspi folder
from kmk.quickpin.raspi.pico import pinout
# or
from kmk.quickpin.raspberry.pico import pinout
# or 
from kmk.quickpin.raspberrypi.pico import pinout

@xs5871
Copy link
Collaborator

xs5871 commented Aug 28, 2023

Of course it looks weird. quickpin is meant to translate physical pin names / mappings from different board layouts. You're translating from the pi pico to the pi pico, which is kind of pointless imo... but if you think that's a good addition, then kmk.quickpin.pico.pico it is.

@kdb424
Copy link
Contributor

kdb424 commented Oct 14, 2023

I've seen some pico clones, but AFIK, I haven't seen any that change the pinout's to the point of having a use for quickpin. The only use I can see for this is not having to find the pinout with an image for people reading the code, but it wouldn't have the intended primary use of quickpin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants