-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to OLED and RGB support #548
base: master
Are you sure you want to change the base?
Improvements to OLED and RGB support #548
Conversation
85c5114
to
5331d2c
Compare
I gave it a quick look over so far super nice improvements! And thank you so much. I am going to test it on a corne and microdox. I also want to give a good read over your oled code and see if we can merge them. I think it would be awesome to have one oled module thats super awesome. But I understand that it may be too much to ask. side note:
|
Thanks @daysgobye ! I'll hop on discord and we can chat further, I'm also rarely in a good spot to have a "linear chat" since I've got a chronic health issue and sometimes dissappears into hospital for a couple of days but I'm more than happy to have a discussion on merging the OLED extensions. This one came from the fact that I wanted to run Peg with a Kyria and 128x64 px displays, something that was tricky with the corner approach in Peg. I like that approach, don't get me wrong, It's probably pretty easy to wrap your head around without getting into the docs. But I wanted to reach all the pixels on the display so I started tinkering with a somewhat different approach as you can see from my code. I'd love to see the (small) performance fixes I did reviewed and maybe merged, they're there to reduce flickering and flashing so make the whole experience feel smoother basically - should I make a separate PR with just these and we can park this PR and have a discussion about the oled code separately? In retrospect, I should have made these changes into separate PR's from the start. |
Alright, @daysgobye I'm cleaning this up a bit - will make one PR with the performance improvements for the Peg oled extension and another for the rgb extension and leaving the "new" oled extension in this PR until we've had a chance to chat about it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey sorry for my super delay in this. I want to get bigger oleds into peg asap I have just been busy with other things sadly.
I have looked over your changes to the peg code and I like what I see all things that should have been there.
looking over your oled extention I like it, it follows the peg extension. If it was up to me we merge it so that people can use it then remove it when we get the two oled extensions merged. I think it is better for the project to have one way we do oleds and it's awesome and covers every use case. I see that there is an argument that it should be " oled " and not "peg_oled". But that's just my 0.02$
This also works with SH1106:
|
This pull requests adds a new OLED module that is not constrained by the Peg client which only supports four corners and does not play well with displays any other size than 128x32 at the moment.
The PR also contains some performance improvements to the peg_oled_display and peg_rgb_matrix extensions, primarily by supporting variable brightness for RGB LEDs and for the OLED screens.
This code has been tested on a Kyria v1.4 running Adafruit KB2040 controllers and "standard Kyria" 128x64 OLEDs.