Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

Commit

Permalink
Flip tangent sign in MikkTSpace
Browse files Browse the repository at this point in the history
https: //github.com/mrdoob/three.js/issues/11438
Change-Id: Ib85c4ed8fbd0b936216cf4a7e129687c0d28d53d
Reviewed-on: https://kuesa-codereview.kdab.com/c/kuesa/kuesa/+/140
Reviewed-by: Paul Lemire <paul.lemire@kdab.com>
  • Loading branch information
Juan Jose Casafranca authored and lemirep committed Jul 1, 2019
1 parent db8c8b4 commit 12cc86f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/core/gltf2importer/meshparser_utils.cpp
Expand Up @@ -409,7 +409,7 @@ SMikkTSpaceInterface createMikkTSpaceInterface()
positionHead[0] = fvTangent[0];
positionHead[1] = fvTangent[1];
positionHead[2] = fvTangent[2];
positionHead[3] = fSign;
positionHead[3] = -fSign;
memcpy(userData->tangentBufferData.data() + vertexIndex * byteStride,
reinterpret_cast<const char *>(&positionHead[0]),
sizeof(positionHead));
Expand Down

0 comments on commit 12cc86f

Please sign in to comment.