fix: crash if samples have different amount of costs associated #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
milianw
requested changes
May 16, 2024
lievenhey
force-pushed
the
fix-flamegraph
branch
3 times, most recently
from
f437e74
to
a06a35e
Compare
milianw
reviewed
May 16, 2024
lievenhey
force-pushed
the
fix-flamegraph
branch
2 times, most recently
from
96603d4
to
76a06b9
Compare
milianw
requested changes
May 17, 2024
If we have a recording with the following layout: A B C where A: part where function f is accessed B: lost samples C: part where function g is accessed then f won't have the lost events cost while g does. This will cause a crash when the model tries to access it. This patch replaces the typedef ItemCost with a real wrapper that will catch the out range access. fixes: #629
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have a recording with the following layout: A B C where A: part where function f is accessed
B: list samples
C: part where function g is accessed
then f won't have the lost events cost while g does. This will cause a crash when the model tries to access it
fixes: #629