Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refreshing project #92

Open
wants to merge 41 commits into
base: master
Choose a base branch
from
Open

Refreshing project #92

wants to merge 41 commits into from

Conversation

philips77
Copy link
Collaborator

@philips77 philips77 commented Aug 25, 2021

This PR introduces the following changes to the library and sample project:

  • Migration to Android Studio Arctic Fox - Patch 1
  • Migration to Kotlin 1.5.30
  • Migration to Java 1.8 (lambdas)
  • Migration to Android BLE Library 2.3.0
  • Fixing all deprecations
    • onActivityCreated -> onViewCreated
    • onActivityResult -> registerForActivityResult
  • Migration from ButterKnife to View Bindings 8f9e5fe
  • Bug fix: McuMgrBleTransport should return errors as error 2e712de, not a response

@philips77 philips77 requested a review from bgiori August 25, 2021 17:21
@philips77 philips77 self-assigned this Aug 25, 2021
@philips77 philips77 marked this pull request as ready for review August 26, 2021 11:46
@philips77 philips77 mentioned this pull request Aug 26, 2021
@philips77
Copy link
Collaborator Author

Btw, the gradle publishing script needs to be updated, or the project won't compile. Locally I uncommeted last lines in build.gradle files for both lib modules.

@twyatt
Copy link
Contributor

twyatt commented Aug 27, 2021

@philips77 I've requested internally that the review requirements be lifted on this repo, or that you be given access to configure the repo as needed. So that you can merge PRs as needed.

@philips77 philips77 removed the request for review from bgiori August 27, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants