Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pandoc_jll #375

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

use pandoc_jll #375

wants to merge 2 commits into from

Conversation

aviatesk
Copy link
Member

@aviatesk aviatesk commented Jun 14, 2020

closes #343

currently this is unfunctional, seemingly because of error in pandoc_jll side.
(upstream issue: https://github.com/JuliaBinaryWrappers/pandoc_jll.jl/issues/1)

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2020

Codecov Report

Merging #375 into master will increase coverage by 2.56%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
+ Coverage   71.71%   74.27%   +2.56%     
==========================================
  Files          25       25              
  Lines        1248     1244       -4     
==========================================
+ Hits          895      924      +29     
+ Misses        353      320      -33     
Flag Coverage Δ
#unittests 74.27% <87.50%> (+2.56%) ⬆️
Impacted Files Coverage Δ
src/writer/pandoc.jl 57.89% <85.71%> (+57.89%) ⬆️
src/rendering/htmlformats.jl 90.74% <100.00%> (+8.92%) ⬆️
src/run.jl 81.35% <0.00%> (+1.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8eca00...24d7dcf. Read the comment docs.

@aviatesk aviatesk changed the title wip: use pandoc_jll use pandoc_jll Jun 14, 2020
@aviatesk aviatesk added the pandoc features using pandoc label Jun 14, 2020
@rikhuijzer
Copy link

You can also use pandoc_crossref and Tectonic via Yggdrasil. I'm using both in https://github.com/rikhuijzer/Books.jl/blob/main/src/build.jl and they work fine. Feel free to copy code.

@TheCedarPrince
Copy link

Hey @pfitzseb - following up from a Slack discussion, what can I do to carry this to be successfully merged into Weave?
Is this still of interest?
I would love to see this merged as I think it would be great for the ecosystem.

@pfitzseb
Copy link
Member

pfitzseb commented Dec 7, 2021

I'd recommend opening a PR against this branch that fixes CI (not sure whether pandoc_jll or Tectonic is the better choice though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pandoc features using pandoc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use pandoc jll
5 participants