Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undo regression in pre-2.0 pandoc support #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tlnagy
Copy link
Collaborator

@tlnagy tlnagy commented Sep 20, 2018

As mentioned in #146, there are a lot of earlier versions of pandoc out there (e.g. the version on Travis is 1.12 AFAIK). This PR adds support back pre-2.0 pandoc support that was eliminated in 4cd0b92.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 87.115% when pulling 1b7fcad on tlnagy:tn/unbreak-pandoc-pre2.0-support into bf57bf8 on mpastell:master.

@tlnagy
Copy link
Collaborator Author

tlnagy commented Oct 18, 2018

Bump @mpastell

@mpastell
Copy link
Collaborator

mpastell commented Jan 3, 2019

Thanks and sorry for leaving this hanging for so long. There are other changes (unfortunately I haven't kept a log of problems I've run into) in pandoc 2.0, at least the same change should apply also to the html output.

@tlnagy
Copy link
Collaborator Author

tlnagy commented Jan 3, 2019

I'm not sure if I understand. This PR fixes the renaming of the --latex-engine flag to --pdf-engine which should only be invoked when generating a PDF?

@tlnagy
Copy link
Collaborator Author

tlnagy commented Jan 8, 2019

bump @mpastell. Can I go ahead and merge this small PR adding back PDF support for pandoc <2.0? I think handling edge cases of pandoc 2.0 is a much bigger PR, but I need this to use Weave.jl at all.

@mpastell
Copy link
Collaborator

mpastell commented Jan 9, 2019

Sorry, I looked through it too quickly. Does the format markdown+raw_tex work with pandoc 1.x? I thought it was added in 2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants